#8232: Adding warnings when a Projection Query has an empty Filter Group #8813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent item when the query has no filters
…turning nothing when there's an empty filter group
BenedekFarkas
commented
Nov 28, 2024
Comment on lines
212
to
213
| // Iterate over each filter group, but ignore empty ones, because they'd cause all content items to be returned. | ||
| foreach (var group in queryRecord.FilterGroups.Where(group => group.Filters.Count > 0)) { |
Member
Author
There was a problem hiding this comment.
This is the only functional change, the rest is just code styling and comment rephrasing.
Member
There was a problem hiding this comment.
I am suggesting adding a limit filter instead (100, 500). And add a notification.
Member
Author
There was a problem hiding this comment.
I didn't find a suitable way to apply such a limit due to how the query is constructed (there is no explicit limit filter) without hurting the abstractions. It is possible to intervene towards the end of the query evaluation when Slice is called (and apply a limit there), but that would mess up paging.
I added a notification instead, when a Query or a ProjectionPart is saved, IMO that's good enough.
…bout the effect of an empty filter group
BenedekFarkas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8232